Skip to content

Conversation

@wrn14897
Copy link
Member

This PR reverts #937

Ref: HDX-2620

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2025

🦋 Changeset detected

Latest commit: 83c687c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/api Patch
@hyperdx/app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview Comment Oct 21, 2025 9:19am

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

@claude
Copy link

claude bot commented Oct 17, 2025

PR Review

This PR reverts the esbuild bundling (PR #937) back to TypeScript compilation. The changes look straightforward and restore the previous build approach.

Issues Found:

  • ⚠️ Potential Docker layer issue in docker/hyperdx/Dockerfile:71 → Copying common-utils/node_modules from node_base stage, but that stage does not exist in the builder flow after removing esbuild. Should likely copy from builder stage instead (verify this stage exists and has the correct modules).

  • ⚠️ Duplicate TypeScript config in packages/api/tsconfig.json:9-12 → Several compiler options (skipLibCheck, sourceMap, strict, target) are already defined in tsconfig.base.json and do not need to be repeated. This creates maintenance issues if base config changes.

Minor Observations:

  • ✅ Proto file path resolution simplified correctly (removed IS_PROD check)
  • ✅ Build script properly copies proto files to build output
  • ✅ Changeset file present for version tracking
  • ✅ Entry scripts updated to use correct paths for unbundled build

Recommendation: Fix the Docker stage reference issue before merging to avoid runtime errors in production.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025

E2E Test Results

All tests passed • 26 passed • 3 skipped • 229s

Status Count
✅ Passed 26
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 3

View full report →

@kodiakhq kodiakhq bot merged commit 131a1c1 into main Oct 21, 2025
9 checks passed
@kodiakhq kodiakhq bot deleted the warren/revert-api-esbuild branch October 21, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants